Re: [Exist-development] servlet's refactoring

[Adam R. <ad...@ex...>]

I am sorry, but I dont understand how this will work or be managed in practice?

2010/1/25 Dmitriy Shabanov <sha...@gm...>:
> "traffic lights" - coding control proposal.
>
> * green - open for commits; after commit switch to yellow until another
> (different person, not commiter) will switch to green or red
>
> * red - no commits (issue description) (warnings to commiter by mail)
>
> "red trunk" does not mean untested code income. It information to be
> tested on different platforms by others (+warning that critical part was
> changed).
>
> Example: I have debian & TC for testing (*nix OS), so I did change
> critical code & I want to be sure that it did not introduce problems on
> another OS. Same time, I don't want more commits before check-up
> completed.
>
> --
> Cheers,
>
> Dmitriy Shabanov
>
> On Mon, 2010-01-25 at 10:05 +0000, Adam Retter wrote:
>> I am concerned by the lack of testing that is being carried out.
>>
>> trunk should always be stable, buildable and useable, this also means
>> that all tests in the test suite should pass. I am also not happy when
>> I see new code being added without new tests. This leads to all sorts
>> of worries and issues such as unmaintainable/ununderstandable code
>> should a commiter leave. The tests should reveal business logic
>> intention and bounds for execution.
>>
>> Branches are fine for writting code and testing yourself, but who else
>> has tested your branch? I would really like to see major changes,
>> tested by more than just one person. This could perhaps be as simple
>> as announcing the feature and request for testing on the mailing list
>> and producing a test release of some sort for those interested users
>> to test. Once their feedback is positive these changes could be merged
>> into trunk.
>>
>>
>> 2010/1/25 Dmitriy Shabanov <sha...@gm...>:
>> > On Mon, Jan 25, 2010 at 3:49 AM, Adam Retter <ad...@ex...> wrote:
>> >>
>> >> On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote:
>> >> > Hello,
>> >> >
>> >> > I did rewrite servlets to integrate servlet's native authentication
>> >> > mechanism
>> >> > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html -
>> >> > SRV.12.5 Authentication)
>> >> >
>> >> > I would like to switch trunk to "red". Waiting for "green" response ...
>> >>
>> >> What does this mean?
>> >>
>> > "Red" trunk mean no commits untill another person confirm that trunk have no
>> > issue (new as minimum)
>> >
>> > --
>> > Dmitriy Shabanov
>> >
>>
>>
>>
>
>



-- 
Adam Retter

eXist Developer
{ United Kingdom }
ad...@ex...
irc://irc.freenode.net/existdb