From: Dmitriy S. <sha...@gm...> - 2010-01-24 15:28:59
Attachments:
smime.p7s
|
Hello, I did rewrite servlets to integrate servlet's native authentication mechanism (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html - SRV.12.5 Authentication) I would like to switch trunk to "red". Waiting for "green" response ... -- Cheers, Dmitriy Shabanov |
From: Adam R. <ad...@ex...> - 2010-01-24 22:49:20
|
On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote: > Hello, > > I did rewrite servlets to integrate servlet's native authentication > mechanism > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html - > SRV.12.5 Authentication) > > I would like to switch trunk to "red". Waiting for "green" response ... What does this mean? > -- > Cheers, > > Dmitriy Shabanov > > ------------------------------------------------------------------------------ > Throughout its 18-year history, RSA Conference consistently attracts the > world's best and brightest in the field, creating opportunities for Conference > attendees to learn about information security's most important issues through > interactions with peers, luminaries and emerging and established companies. > http://p.sf.net/sfu/rsaconf-dev2dev > _______________________________________________ > Exist-development mailing list > Exi...@li... > https://lists.sourceforge.net/lists/listinfo/exist-development > > -- Adam Retter eXist Developer { United Kingdom } ad...@ex... irc://irc.freenode.net/existdb |
From: Dannes W. <di...@ex...> - 2010-01-25 07:34:30
|
Hi, On Sun, Jan 24, 2010 at 11:49 PM, Adam Retter <ad...@ex...> wrote: > > I would like to switch trunk to "red". Waiting for "green" response ... > > What does this mean? > I think it is the TDD paradigm..... IMO we must try to have 'trunk' stable at all time, because people rely on it. If invasive / risky changes are made, never do it in trunk. We'll lose credibility if we make mistakes here. For risky changes, a short lived branch should be created. Probably for the openid changes, a branch would have been a good idea as well. regards Dannes -- eXist-db Native XML Database - http://exist-db.org Join us on linked-in: http://www.linkedin.com/groups?gid=35624 |
From: Dmitriy S. <sha...@gm...> - 2010-01-25 07:50:11
|
People did ask to inform about critical changes, so I did it. And openid was on branch for 2 months. On Mon, Jan 25, 2010 at 12:34 PM, Dannes Wessels <di...@ex...>wrote: > Hi, > > > On Sun, Jan 24, 2010 at 11:49 PM, Adam Retter <ad...@ex...> wrote: > >> > I would like to switch trunk to "red". Waiting for "green" response ... >> >> What does this mean? >> > > I think it is the TDD paradigm..... > > IMO we must try to have 'trunk' stable at all time, because people rely on > it. If invasive / risky changes are made, never do it in trunk. We'll lose > credibility if we make mistakes here. > > For risky changes, a short lived branch should be created. Probably for the > openid changes, a branch would have been a good idea as well. > > regards > > Dannes > > -- > eXist-db Native XML Database - http://exist-db.org > Join us on linked-in: http://www.linkedin.com/groups?gid=35624 > -- Dmitriy Shabanov |
From: Adam R. <ad...@ex...> - 2010-01-25 10:05:30
|
I am concerned by the lack of testing that is being carried out. trunk should always be stable, buildable and useable, this also means that all tests in the test suite should pass. I am also not happy when I see new code being added without new tests. This leads to all sorts of worries and issues such as unmaintainable/ununderstandable code should a commiter leave. The tests should reveal business logic intention and bounds for execution. Branches are fine for writting code and testing yourself, but who else has tested your branch? I would really like to see major changes, tested by more than just one person. This could perhaps be as simple as announcing the feature and request for testing on the mailing list and producing a test release of some sort for those interested users to test. Once their feedback is positive these changes could be merged into trunk. 2010/1/25 Dmitriy Shabanov <sha...@gm...>: > On Mon, Jan 25, 2010 at 3:49 AM, Adam Retter <ad...@ex...> wrote: >> >> On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote: >> > Hello, >> > >> > I did rewrite servlets to integrate servlet's native authentication >> > mechanism >> > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html - >> > SRV.12.5 Authentication) >> > >> > I would like to switch trunk to "red". Waiting for "green" response ... >> >> What does this mean? >> > "Red" trunk mean no commits untill another person confirm that trunk have no > issue (new as minimum) > > -- > Dmitriy Shabanov > -- Adam Retter eXist Developer { United Kingdom } ad...@ex... irc://irc.freenode.net/existdb |
From: Dmitriy S. <sha...@gm...> - 2010-01-25 13:54:15
Attachments:
smime.p7s
|
"traffic lights" - coding control proposal. * green - open for commits; after commit switch to yellow until another (different person, not commiter) will switch to green or red * red - no commits (issue description) (warnings to commiter by mail) "red trunk" does not mean untested code income. It information to be tested on different platforms by others (+warning that critical part was changed). Example: I have debian & TC for testing (*nix OS), so I did change critical code & I want to be sure that it did not introduce problems on another OS. Same time, I don't want more commits before check-up completed. -- Cheers, Dmitriy Shabanov On Mon, 2010-01-25 at 10:05 +0000, Adam Retter wrote: > I am concerned by the lack of testing that is being carried out. > > trunk should always be stable, buildable and useable, this also means > that all tests in the test suite should pass. I am also not happy when > I see new code being added without new tests. This leads to all sorts > of worries and issues such as unmaintainable/ununderstandable code > should a commiter leave. The tests should reveal business logic > intention and bounds for execution. > > Branches are fine for writting code and testing yourself, but who else > has tested your branch? I would really like to see major changes, > tested by more than just one person. This could perhaps be as simple > as announcing the feature and request for testing on the mailing list > and producing a test release of some sort for those interested users > to test. Once their feedback is positive these changes could be merged > into trunk. > > > 2010/1/25 Dmitriy Shabanov <sha...@gm...>: > > On Mon, Jan 25, 2010 at 3:49 AM, Adam Retter <ad...@ex...> wrote: > >> > >> On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote: > >> > Hello, > >> > > >> > I did rewrite servlets to integrate servlet's native authentication > >> > mechanism > >> > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html - > >> > SRV.12.5 Authentication) > >> > > >> > I would like to switch trunk to "red". Waiting for "green" response ... > >> > >> What does this mean? > >> > > "Red" trunk mean no commits untill another person confirm that trunk have no > > issue (new as minimum) > > > > -- > > Dmitriy Shabanov > > > > > |
From: Adam R. <ad...@ex...> - 2010-01-25 14:15:43
|
I am sorry, but I dont understand how this will work or be managed in practice? 2010/1/25 Dmitriy Shabanov <sha...@gm...>: > "traffic lights" - coding control proposal. > > * green - open for commits; after commit switch to yellow until another > (different person, not commiter) will switch to green or red > > * red - no commits (issue description) (warnings to commiter by mail) > > "red trunk" does not mean untested code income. It information to be > tested on different platforms by others (+warning that critical part was > changed). > > Example: I have debian & TC for testing (*nix OS), so I did change > critical code & I want to be sure that it did not introduce problems on > another OS. Same time, I don't want more commits before check-up > completed. > > -- > Cheers, > > Dmitriy Shabanov > > On Mon, 2010-01-25 at 10:05 +0000, Adam Retter wrote: >> I am concerned by the lack of testing that is being carried out. >> >> trunk should always be stable, buildable and useable, this also means >> that all tests in the test suite should pass. I am also not happy when >> I see new code being added without new tests. This leads to all sorts >> of worries and issues such as unmaintainable/ununderstandable code >> should a commiter leave. The tests should reveal business logic >> intention and bounds for execution. >> >> Branches are fine for writting code and testing yourself, but who else >> has tested your branch? I would really like to see major changes, >> tested by more than just one person. This could perhaps be as simple >> as announcing the feature and request for testing on the mailing list >> and producing a test release of some sort for those interested users >> to test. Once their feedback is positive these changes could be merged >> into trunk. >> >> >> 2010/1/25 Dmitriy Shabanov <sha...@gm...>: >> > On Mon, Jan 25, 2010 at 3:49 AM, Adam Retter <ad...@ex...> wrote: >> >> >> >> On 24 January 2010 15:27, Dmitriy Shabanov <sha...@gm...> wrote: >> >> > Hello, >> >> > >> >> > I did rewrite servlets to integrate servlet's native authentication >> >> > mechanism >> >> > (http://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html - >> >> > SRV.12.5 Authentication) >> >> > >> >> > I would like to switch trunk to "red". Waiting for "green" response ... >> >> >> >> What does this mean? >> >> >> > "Red" trunk mean no commits untill another person confirm that trunk have no >> > issue (new as minimum) >> > >> > -- >> > Dmitriy Shabanov >> > >> >> >> > > -- Adam Retter eXist Developer { United Kingdom } ad...@ex... irc://irc.freenode.net/existdb |