exist-development

[Exist-development] XSL PI and REST

[José M. F. G. <jm...@us...>]

Hi everybody,
	I have just realized that RESTServer enables XSL PI processing by default, even when it is explicitly disabled in conf.xml through '<serializer enable-xsl="no" ...'. Is there some (unknown) reason for this odd behavior? If it is not, I would like to fix it.

	Best Regards,
		José María
-- 
"La violencia es el último recurso del incompetente"
	- Salvor Hardin en "La Fundación" de Isaac Asimov
"Premature optimization is the root of all evil." - Donald Knuth

José María Fernández González
e-mail: jos...@gm...

Re: [Exist-development] XSL PI and REST

[José M. F. G. <jm...@us...>]

Hi again,
	I opened bug #3008137 at Sourceforge about this issue, where I'm describing the problem, and a quick fix. If there is no objection, I would like to apply that fix on trunk on Wednesday.

	José María

On 05/27/10 20:02, José María Fernández González wrote:
> Hi everybody,
> I have just realized that RESTServer enables XSL PI processing by
> default, even when it is explicitly disabled in conf.xml through
> '<serializer enable-xsl="no" ...'. Is there some (unknown) reason for
> this odd behavior? If it is not, I would like to fix it.
>
> Best Regards,
> José María

-- 
"La violencia es el último recurso del incompetente"
	- Salvor Hardin en "La Fundación" de Isaac Asimov
"Premature optimization is the root of all evil." - Donald Knuth

José María Fernández González
e-mail: jos...@gm...

Re: [Exist-development] XSL PI and REST

[Dmitriy S. <sha...@gm...>]

Can we add on option auto-no (auto-yes, yes, no) at serializer
configuration? or something ... for now the behavior is quite clear - files'
PI instructions have higher priority, so we need on option to change
priority.

2010/5/31 José María Fernández González <jm...@us...>

> Hi again,
>        I opened bug #3008137 at Sourceforge about this issue, where I'm
> describing the problem, and a quick fix. If there is no objection, I would
> like to apply that fix on trunk on Wednesday.
>
>        José María
>
> On 05/27/10 20:02, José María Fernández González wrote:
> > Hi everybody,
> > I have just realized that RESTServer enables XSL PI processing by
> > default, even when it is explicitly disabled in conf.xml through
> > '<serializer enable-xsl="no" ...'. Is there some (unknown) reason for
> > this odd behavior? If it is not, I would like to fix it.
>

-- 
Dmitriy Shabanov

Re: [Exist-development] XSL PI and REST

[José M. F. G. <jm...@us...>]

Hi Dmitryi,
	the serializer already has that option at conf.xml level for XSL PIs, and that's the reason about these e-mails: the configuration option from conf.xml is not honored (i.e. is ignored) on REST because hardcoded defaults from REST module for this option (and others) are passed to the serializer, so global defaults are ignored/bypassed.

On 06/01/10 14:21, Dmitriy Shabanov wrote:
> Can we add on option auto-no (auto-yes, yes, no) at serializer
> configuration? or something ... for now the behavior is quite clear -
> files' PI instructions have higher priority, so we need on option to
> change priority.
>
> 2010/5/31 José María Fernández González <jm...@us...
> <mailto:jm...@us...>>
>
>     Hi again,
>             I opened bug #3008137 at Sourceforge about this issue, where
>     I'm describing the problem, and a quick fix. If there is no
>     objection, I would like to apply that fix on trunk on Wednesday.
>
>             José María
>
>     On 05/27/10 20:02, José María Fernández González wrote:
>      > Hi everybody,
>      > I have just realized that RESTServer enables XSL PI processing by
>      > default, even when it is explicitly disabled in conf.xml through
>      > '<serializer enable-xsl="no" ...'. Is there some (unknown) reason for
>      > this odd behavior? If it is not, I would like to fix it.
>
> --
> Dmitriy Shabanov

-- 
"La violencia es el último recurso del incompetente"
	- Salvor Hardin en "La Fundación" de Isaac Asimov
"Premature optimization is the root of all evil." - Donald Knuth

José María Fernández González
e-mail: jos...@gm...

Re: [Exist-development] XSL PI and REST

[Dmitriy S. <sha...@gm...>]

Hi,

For now, PI instructions have higher priority than conf.xml settings, I
recommend to add option that will control that priority: <serializer
master="PI-conf" enable-xsl="no" - mean PI instruction will overwrite conf's
one, <serializer master="conf-PI" enable-xsl="no" - PI will be ignored
-- 
Dmitriy Shabanov
2010/6/1 José María Fernández González <jm...@us...>

> Hi Dmitryi,
>        the serializer already has that option at conf.xml level for XSL
> PIs, and that's the reason about these e-mails: the configuration option
> from conf.xml is not honored (i.e. is ignored) on REST because hardcoded
> defaults from REST module for this option (and others) are passed to the
> serializer, so global defaults are ignored/bypassed.
>
>
> On 06/01/10 14:21, Dmitriy Shabanov wrote:
>
>> Can we add on option auto-no (auto-yes, yes, no) at serializer
>> configuration? or something ... for now the behavior is quite clear -
>> files' PI instructions have higher priority, so we need on option to
>> change priority.
>>
>> 2010/5/31 José María Fernández González <jm...@us...
>> <mailto:jm...@us...>>
>>
>>
>>    Hi again,
>>            I opened bug #3008137 at Sourceforge about this issue, where
>>    I'm describing the problem, and a quick fix. If there is no
>>    objection, I would like to apply that fix on trunk on Wednesday.
>>
>>            José María
>>
>>    On 05/27/10 20:02, José María Fernández González wrote:
>>     > Hi everybody,
>>     > I have just realized that RESTServer enables XSL PI processing by
>>     > default, even when it is explicitly disabled in conf.xml through
>>     > '<serializer enable-xsl="no" ...'. Is there some (unknown) reason
>> for
>>     > this odd behavior? If it is not, I would like to fix it.
>>
>

Re: [Exist-development] XSL PI and REST

[José M. F. G. <jm...@us...>]

Hi Dmitriy,
	but then, which is the meaning of "<serializer enable-xsl='...'" if it is being ignored? AFAIHS currently, at WebDAV level the configuration option is bypassed by module defaults (not to apply/follow XSL PIs, which is reasonable for such protocol), at REST level it is bypassed by its defaults (to apply/follow XSL PIs), at backup level it is obviously forced to not apply/follow XSL PIs (very reasonable), at org.exist.xmldb.LocalCollection level it is bypassed by its defaults (not to apply/follow XSL PIs, again reasonable), ...

	So, there are very few key places in eXist code where that configuration option is being taken into account. The documentation of "<serializer enable-xsl='...'" configuration option should be improved, explaining its scope, and from my point of view, it should control the default behavior of REST interface.

	Cheers,
		José María

On 06/02/10 06:22, Dmitriy Shabanov wrote:
> Hi,
> For now, PI instructions have higher priority than conf.xml settings, I
> recommend to add option that will control that priority: <serializer
> master="PI-conf" enable-xsl="no" - mean PI instruction will overwrite
> conf's one, <serializer master="conf-PI" enable-xsl="no" - PI will be
> ignored
> --
> Dmitriy Shabanov
> 2010/6/1 José María Fernández González <jm...@us...
> <mailto:jm...@us...>>
>
>     Hi Dmitryi,
>             the serializer already has that option at conf.xml level for
>     XSL PIs, and that's the reason about these e-mails: the
>     configuration option from conf.xml is not honored (i.e. is ignored)
>     on REST because hardcoded defaults from REST module for this option
>     (and others) are passed to the serializer, so global defaults are
>     ignored/bypassed.
>
>
>     On 06/01/10 14:21, Dmitriy Shabanov wrote:
>
>         Can we add on option auto-no (auto-yes, yes, no) at serializer
>         configuration? or something ... for now the behavior is quite
>         clear -
>         files' PI instructions have higher priority, so we need on option to
>         change priority.
>
>         2010/5/31 José María Fernández González
>         <jm...@us... <mailto:jm...@us...>
>         <mailto:jm...@us...
>         <mailto:jm...@us...>>>
>
>
>             Hi again,
>                     I opened bug #3008137 at Sourceforge about this
>         issue, where
>             I'm describing the problem, and a quick fix. If there is no
>             objection, I would like to apply that fix on trunk on Wednesday.
>
>                     José María
>
>             On 05/27/10 20:02, José María Fernández González wrote:
>          > Hi everybody,
>          > I have just realized that RESTServer enables XSL PI processing by
>          > default, even when it is explicitly disabled in conf.xml through
>          > '<serializer enable-xsl="no" ...'. Is there some (unknown)
>         reason for
>          > this odd behavior? If it is not, I would like to fix it.
>

-- 
"La violencia es el último recurso del incompetente"
	- Salvor Hardin en "La Fundación" de Isaac Asimov
"Premature optimization is the root of all evil." - Donald Knuth

José María Fernández González
e-mail: jos...@gm...

Re: [Exist-development] XSL PI and REST

[Dmitriy S. <sha...@gm...>]

Core team, where are you?

-- 
Cheers,

Dmitriy Shabanov

On Wed, 2010-06-02 at 11:35 +0200, José María Fernández González wrote:
> Hi Dmitriy,
> 	but then, which is the meaning of "<serializer enable-xsl='...'" if it is being ignored? AFAIHS currently, at WebDAV level the configuration option is bypassed by module defaults (not to apply/follow XSL PIs, which is reasonable for such protocol), at REST level it is bypassed by its defaults (to apply/follow XSL PIs), at backup level it is obviously forced to not apply/follow XSL PIs (very reasonable), at org.exist.xmldb.LocalCollection level it is bypassed by its defaults (not to apply/follow XSL PIs, again reasonable), ...
> 
> 	So, there are very few key places in eXist code where that configuration option is being taken into account. The documentation of "<serializer enable-xsl='...'" configuration option should be improved, explaining its scope, and from my point of view, it should control the default behavior of REST interface.
> 
> 	Cheers,
> 		José María
> 
> On 06/02/10 06:22, Dmitriy Shabanov wrote:
> > Hi,
> > For now, PI instructions have higher priority than conf.xml settings, I
> > recommend to add option that will control that priority: <serializer
> > master="PI-conf" enable-xsl="no" - mean PI instruction will overwrite
> > conf's one, <serializer master="conf-PI" enable-xsl="no" - PI will be
> > ignored
> > --
> > Dmitriy Shabanov
> > 2010/6/1 José María Fernández González <jm...@us...
> > <mailto:jm...@us...>>
> >
> >     Hi Dmitryi,
> >             the serializer already has that option at conf.xml level for
> >     XSL PIs, and that's the reason about these e-mails: the
> >     configuration option from conf.xml is not honored (i.e. is ignored)
> >     on REST because hardcoded defaults from REST module for this option
> >     (and others) are passed to the serializer, so global defaults are
> >     ignored/bypassed.
> >
> >
> >     On 06/01/10 14:21, Dmitriy Shabanov wrote:
> >
> >         Can we add on option auto-no (auto-yes, yes, no) at serializer
> >         configuration? or something ... for now the behavior is quite
> >         clear -
> >         files' PI instructions have higher priority, so we need on option to
> >         change priority.
> >
> >         2010/5/31 José María Fernández González
> >         <jm...@us... <mailto:jm...@us...>
> >         <mailto:jm...@us...
> >         <mailto:jm...@us...>>>
> >
> >
> >             Hi again,
> >                     I opened bug #3008137 at Sourceforge about this
> >         issue, where
> >             I'm describing the problem, and a quick fix. If there is no
> >             objection, I would like to apply that fix on trunk on Wednesday.
> >
> >                     José María
> >
> >             On 05/27/10 20:02, José María Fernández González wrote:
> >          > Hi everybody,
> >          > I have just realized that RESTServer enables XSL PI processing by
> >          > default, even when it is explicitly disabled in conf.xml through
> >          > '<serializer enable-xsl="no" ...'. Is there some (unknown)
> >         reason for
> >          > this odd behavior? If it is not, I would like to fix it.
> >
> 

Re: [Exist-development] XSL PI and REST

[José M. F. G. <jm...@us...>]

It seems core team is very busy these days. I have updated bug #3008137 with some bits from my previous e-mail, so there is more information there when they have a look at the bug report.

On 06/02/10 18:39, Dmitriy Shabanov wrote:
> Core team, where are you?
>

-- 
"La violencia es el último recurso del incompetente"
	- Salvor Hardin en "La Fundación" de Isaac Asimov
"Premature optimization is the root of all evil." - Donald Knuth

José María Fernández González
e-mail: jos...@gm...