From: <pau...@us...> - 2007-05-22 23:13:10
|
Revision: 959 http://svn.sourceforge.net/everydevel/?rev=959&view=rev Author: paul_the_nomad Date: 2007-05-22 16:13:06 -0700 (Tue, 22 May 2007) Log Message: ----------- FIX: 'wrap' attribute is not XHTML compliant Modified Paths: -------------- trunk/ebase/lib/Everything/HTML/FormObject/Test/TextArea.pm trunk/ebase/lib/Everything/HTML/FormObject/TextArea.pm Property Changed: ---------------- trunk/ebase/ Property changes on: trunk/ebase ___________________________________________________________________ Name: svk:merge - 16c2b9cb-492b-4d64-9535-64d4e875048d:/wip/ebase:985 a6810612-c0f9-0310-9d3e-a9e4af8c5745:/ebase/offline:17930 + 16c2b9cb-492b-4d64-9535-64d4e875048d:/wip/ebase:992 a6810612-c0f9-0310-9d3e-a9e4af8c5745:/ebase/offline:17930 Modified: trunk/ebase/lib/Everything/HTML/FormObject/Test/TextArea.pm =================================================================== --- trunk/ebase/lib/Everything/HTML/FormObject/Test/TextArea.pm 2007-05-22 23:12:39 UTC (rev 958) +++ trunk/ebase/lib/Everything/HTML/FormObject/Test/TextArea.pm 2007-05-22 23:13:06 UTC (rev 959) @@ -10,7 +10,7 @@ use SUPER; use warnings; -sub test_gen_object : Test(15) { +sub test_gen_object : Test(13) { my $self = shift; my $instance = Test::MockObject::Extends->new( $self->{instance} ); my $cgi = Test::MockObject->new; @@ -35,7 +35,7 @@ is( $params[0], - 'query, bindNode, field, name, default, cols, rows, wrap ' . $cgi + 'query, bindNode, field, name, default, cols, rows ' . $cgi . ' bN f n d c r w', 'genObject() should call getParamArray() with @_' ); @@ -47,7 +47,6 @@ is( $args->[2], 'n', '... should use provided name' ); is( $args->[6], 'c', '... should use provided cols' ); is( $args->[8], 'r', '... should use provided rows' ); - is( $args->[10], 'w', '... should use provided wrap' ); is( $result, "html\na", '... returning concatenation of SUPER() and textfield() calls' ); @@ -57,7 +56,6 @@ '... with no default value, should bind to node field (if provided)' ); is( $args->[6], 80, '... cols should default to 80' ); is( $args->[8], 20, '... rows should default to 20' ); - is( $args->[10], 'virtual', '... wrap should default to "virtual"' ); is( $args->[2], 'f', '... name should default to node field name' ); $instance->genObject( $cgi, '', 'f', 'n', '' ); Modified: trunk/ebase/lib/Everything/HTML/FormObject/TextArea.pm =================================================================== --- trunk/ebase/lib/Everything/HTML/FormObject/TextArea.pm 2007-05-22 23:12:39 UTC (rev 958) +++ trunk/ebase/lib/Everything/HTML/FormObject/TextArea.pm 2007-05-22 23:13:06 UTC (rev 959) @@ -70,16 +70,16 @@ sub genObject { my $this = shift @_; - my ( $query, $bindNode, $field, $name, $default, $cols, $rows, $wrap ) = + my ( $query, $bindNode, $field, $name, $default, $cols, $rows, ) = getParamArray( - "query, bindNode, field, name, default, cols, rows, wrap", @_ ); + "query, bindNode, field, name, default, cols, rows ", @_ ); $name ||= $field; $default ||= 'AUTO'; $cols ||= 80; $rows ||= 20; - $wrap ||= 'virtual'; + my $html = $this->SUPER::genObject( $query, $bindNode, $field, $name ) . "\n"; @@ -94,7 +94,6 @@ -default => $default, -cols => $cols, -rows => $rows, - -wrap => $wrap ); return $html; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |