Mistake in at91_efc.c

Brought to you by: astralix, haraldkipp, hwmaier, olereinhardt, and 3 others

#38 Mistake in at91_efc.c

Status: pending-works-for-me

Owner: Ole Reinhardt

Labels: RTOS - General (10)

Priority: 5

Updated: 2013-04-29

Created: 2013-01-29

Creator: Anonymous

Private: No

in At91EfcSectorWrite;page number is calculated in a wrong way from give offset

Discussion

Nobody/Anonymous - 2013-01-29

patch-at91efc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ole Reinhardt - 2013-04-29

I don't see any problem with the page offset calculation in the current
trunk. The patch would change

off & MC_PAGEN_MASK

to

((off / PAGE_SIZE) << 8) & MC_PAGEN_MASK

Problem:

PAGE_SIZE is not defined in this context.

However, the PAGE_SIZE of the At91 efc is 256 bytes, so

((off / PAGE_SIZE) << 8) & MC_PAGEN_MASK

Is exactly the same as

off & MC_PAGEN_MASK

is'nt it?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ole Reinhardt - 2013-04-29

assigned_to: nobody --> olereinhardt

labels: --> RTOS - General

status: open --> pending-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: