ethernut-devel — Ethernut developer's forum

[Ethernut-devel] bug in code NutTcpConnect

[Pete A. <SC...@ho...>]

Hi Harald and Michael,

I've encountered a small problem; when a NutTcpConnect fails it still
returns 0.
It allways returns 0, that is not good.

So I changed the code in tcpsm.c.
Now when a connection attempt is not successful it returns -1.

Regards,
Peter


See code below:

int NutTcpStateActiveOpenEvent(TCPSOCKET *sock)
{
    /*
     * Despite RFC793 we do not allow a passive
     * open to become active.
     */
    if(sock->so_state == TCPS_LISTEN)
        return (sock->so_last_error = EOPNOTSUPP);
    if(sock->so_state != TCPS_CLOSED)
        return (sock->so_last_error = EISCONN);

 /*
  * Switch state to SYN_SENT. This will
  * transmit a SYN packet.
  */
    NutTcpStateChange(sock, TCPS_SYN_SENT);

    /*
     * Block application.
     */
    NutEventWait(&sock->so_ac_tq, 0);


// *************************** return additional info
******************************************
//   NutKPrintFormat("socket state= %d \n", sock->so_state);
    if(sock->so_state != TCPS_ESTABLISHED)
        return -1;
//
****************************************************************************
**********
    return 0;
}

[Ethernut-devel] First poster here ?

[Marc R. W. <mw...@gm...>]

I just found the Ethernut mailing list.

I want to say hello to everybody using this great little
piece of hard- and software.

Here you soon :)

Marc Wetzel