>Quick google'ing gave mention of 5 or 15 as symlinks depth, I think Linus
>didn't agree to upping the limit to 15 finally.
>I just introduced a constant NFS_MAXLINKDEPTH into CVS (in
>etherboot.h), set to 16 to go for sure. At least one thing we
>definitively are "better" than the Linux kernel ;-)
Anselm,
There's an obscure bug in your code waiting to bite someday. You declare
"recursion" as a static int set to 0. Problem is if Etherboot restarts,
this will not get reset to 0 and sometime later, when NFS access through
symlinks is retried, the limit will be exceeded, even though it's a
fresh attempt to load the file.
|