Re: [Etherboot-developers] Bug in DHCP request packet format

[<ke...@us...>]

>In etherboot 5.1.8 NIC.C, this change:
>-------------------------------
>@@ -782,7 +782,7 @@
>  /* Append machine_info to end, in encapsulated option */
>  bp_vend = ip.bp.bp_vend + sizeof rfc1533_cookie + sizeof dhcpdiscover;
>  memcpy(bp_vend, dhcp_machine_info, DHCP_MACHINE_INFO_SIZE);
>- bp_vend += sizeof DHCP_MACHINE_INFO_SIZE;
>+ bp_vend += DHCP_MACHINE_INFO_SIZE;
>  *bp_vend++ = RFC1533_END;
> #endif /* NO_DHCP_SUPPORT */
>-------------------------------
>will correct a bug in the creation of the DHCP Request packet that
>effectively truncates dhcp_machine_info to first 4 bytes (I checked the
>assembly produced by the compiler).
>
>This bug seems to only affect the 5.1.x chain.

Many thanks. Committed to CVS.