Re: [Etherboot-developers] Uninitialized 'iplen' in nic.c
Brought to you by:
marty_connor,
stefanhajnoczi
|
From: <ebi...@ln...> - 2003-05-03 13:55:55
|
"Robb Main" <ma...@ac...> writes: > > please use diff -u next time. It is a whole lot more readable. > > Thanks for the pointer, new patch attached. > > > I have a big problem with the patch. It does exactly the opposite > > of what it is supposed to do. It adds a case where iplen will > > be used initialized. In particular you take out the surrounding > > test for ip. You cannot have a udp unless it is also an ip packet. > > But you can sure have a packet that is not a ip packet. > > I hope the problem is due to the difficulty in readability, and not because > I'm missing something... Yes. The change looks correct. I still have reservations about fixing things just because the compiler cannot follow data dependencies. But there is also a very practical point of keeping the warning count low in production code, so the warnings that show up are about real things. Eric |