Re: [Etherboot-developers] tg3 progress...

[<ebi...@ln...>]

ebi...@ln... (Eric W. Biederman) writes:

> ebi...@ln... (Eric W. Biederman) writes:
> 
> > Well I instead made the code work so I could be more certain
> > of my cutting so I have a working driver in:
> > 3726 lines of code.
> > 
> > Hopefully tomorrow I can find something to prune away.  It looks like I must
> > trim it with a thousand cuts, so...
> 
> One little snip at a time.  I have done the basic analysis and know where
> the big chunks of code are, and have just started the small snips to
> make the driver smaller.  I have the code down to  3458 lines of
> code and reduced in size by a 1/2 or so.
> 
> In another week I might even have a small comprehensible driver.

Of course I am dreaming but progress is being made.

The driver is now down to 2700 lines, of code.  And the text segment
has reduced in size from about 17K to 14K.  So far this was achieved
with a bit of dead code elimination but mostly by introducing
tables of register/value pairs to initialize the chip, and introducing
small subroutines to handle the common idioms.

I don't know if there is any opportunity to squeeze the tg3 driver or not,
we shall see.

I have committed this most recent version, and checked in some bug
fixes with respect to handling of 64bit bars.  Basically in etherboot
we now return an error if the top half of a 64bit bar is populated
and we are on a 32bit platform.

I had a bug in LinuxBIOS that let that left the top half of the BAR
populated and the driver failed in entertaining ways.

Eric