RE: [Etherboot-developers] PCI_CONFIG patch

[Timothy L. <tim...@us...>]

> That looks about right.
> 
> I am trying to think which errors this cause and how it interacts
> with everything.
> 
> There are two ways to handle conditional code like this and at
> the moment I am not certain which is best.
> 
> a) just conditionally compile the contents of the file.
> b) unconditionally compile the contents of the file and stick
>    it in a library only if needed.
> 
> For the rest of the pci code we already do #ifdef CONFIG_PCI
> around it.  So this looks like a reasonable solution.
> 
> Could you move the #ifdef CONFIG_PCI up 2 lines and make
> that last #endif, #endif /* CONFIG_PCI */ so we know it covers
> the entire file?  Other than that it looks good.

Will do, I will commit the change later today...