Re: [Etherboot-developers] PCI_CONFIG patch
Brought to you by:
marty_connor,
stefanhajnoczi
|
From: <ebi...@ln...> - 2003-01-24 05:32:10
|
"Timothy Legge" <tim...@us...> writes: > Hi > > Looking for the "486 R" problem, I decided to disable PCI by removeing > -DCONFIG_PCI from the Config file. As a result, I received errors > trying to compile pci_io.c. I did the following, but since I don't know > if this is the best way to handle it, I did not cvs it. With the patch > in place, everything seemed to compile correctly. That looks about right. I am trying to think which errors this cause and how it interacts with everything. There are two ways to handle conditional code like this and at the moment I am not certain which is best. a) just conditionally compile the contents of the file. b) unconditionally compile the contents of the file and stick it in a library only if needed. For the rest of the pci code we already do #ifdef CONFIG_PCI around it. So this looks like a reasonable solution. Could you move the #ifdef CONFIG_PCI up 2 lines and make that last #endif, #endif /* CONFIG_PCI */ so we know it covers the entire file? Other than that it looks good. Eric > Tim > > *** arch/i386/core/pci_io.c Tue Jan 21 19:59:32 2003 > --- arch/i386/core/pci_io.c-new Tue Jan 21 20:01:49 2003 > *************** > *** 12,17 **** > --- 12,18 ---- > */ > #include "etherboot.h" > #include "pci.h" > + #ifdef CONFIG_PCI > #ifdef CONFIG_PCI_DIRECT > #define PCIBIOS_SUCCESSFUL 0x00 > > *************** void find_pci(int type, struct pci_devic > *** 332,334 **** > --- 333,336 ---- > #endif > return scan_pci_bus(type, dev); > } > + #endif > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Scholarships for Techies! > Can't afford IT training? All 2003 ictp students receive scholarships. > Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more. > www.ictp.com/training/sourceforge.asp > _______________________________________________ > Etherboot-developers mailing list > Eth...@li... > https://lists.sourceforge.net/lists/listinfo/etherboot-developers |