Re: [Etherboot-developers] [Commit] Prism2 CVS Update.

[Michael B. <mb...@fe...>]

On Mon, 23 Dec 2002, Ken Yap wrote:
> >Hello, This is my first .diff patch based from the latest etherboot 5.0.xx
> >cvs. This updates the prism2 driver to the latest linux-wlan 0.1.16pre8.
> >- This should enable a workaround for spurious interrupts generated before
> >initialization
> >    is complete.(I had problems with)
> >- Some more error checking.
> >Can anyone take a look at it for any errors? I would like to get it
> >submitted into cvs.
> Hope Michael is reading this. I think the spinlock code isn't needed
> because there is only one process running, but if it doesn't cause
> problems, as it doesn't use up much space it might be good to retain a
> resemblance to the original Linux driver.

Have reviewed.  Most looks fine.  The structure of the Etherboot driver is
that the .h files are lifted straight from linux-wlan-ng, while the .c
files are reverse-engineered from it.  All changes to the .h files are
therefore fine, assuming that they merely update the files to match the
latest linux-wlan-ng.

The spinlock code should not be there.  The Etherboot code in prism2.c is
different enough from the Linux driver that it is not worth retaining
extra code that has no practical purpose.  I therefore recommend rejecting
all changes to prism2.c except for the addition of prism2_reset.  There is
another problem: the prototype of prism2_reset in the patch is incorrect.
This will have to be slightly reworked.

In summary: feel free to commit changes to the header files, hold off on
the changes to prism2.c.  I will edit the patch and check in the changes
to prism2.c some time after Christmas: someone please remind me if I
haven't done it by New Year's Day.

I'm unlikely to read any replies in the next week or so, so please don't
think I'm being rude and ignoring them!

Merry Christmas to all.

Michael Brown
http://www.fensystems.co.uk