Re: [Etherboot-developers] Etherboot 5.1.2rc7 released

[<ebi...@ln...>]

Doug Ambrisko <amb...@am...> writes:

> Eric W. Biederman writes:
> | Doug Ambrisko <amb...@am...> writes:
> | If you build a relocateable image this problem will go away, as etherboot
> | will then live at the true top of memory.  And since you are using an
> | eepro100 that should not be a problem.  The e1000 and the e100 have
> | been both tested, with relocation, and multicasting support.
> | -DRELOCATION.
> 
> I'll try that.
>  
> | > diff -r -u etherboot-5.1.2rc7.orig/src/nrv2b.c
> etherboot-5.1.2rc7/src/nrv2b.c
> 
> | > --- etherboot-5.1.2rc7.orig/src/nrv2b.c	Wed Aug 21 13:00:14 2002
> | > +++ etherboot-5.1.2rc7/src/nrv2b.c	Mon Oct 21 09:05:20 2002
> | > @@ -36,7 +36,11 @@
> | >  #include <string.h>
> | >  #include <ctype.h>
> | >  #include <errno.h>
> | > +#ifdef __FreeBSD__
> | > +#include <inttypes.h>
> | > +#else
> | >  #include <stdint.h>
> | > +#endif
> | >  #include <limits.h>
> | >  #include <assert.h>
> | >  #if UCLPACK_COMPAT
> | > diff -r -u etherboot-5.1.2rc7.orig/src/osloader.c
> | > etherboot-5.1.2rc7/src/osloader.c
> | 
> | You don't have a standards compliant C setup?
> | I know stdint.h was introduced in something like C95 or C99 but that
> | was at least three years ago.
> 
> 4.X -stable was released a relatively long while ago.  It's in
> 5.0 -current stream to be released.  Eventually it won't be needed.  
> Maybe you have a better solution?  A bunch of people do use 
> Etherboot on FreeBSD.

Good question.  Probably a configure script or something.
 
> | Sorry about that.  Would it be possible to setup the FreeBSD compile
> | so it can compile on something besides FreeBSD so these kinds of
> | things can at least be compile tested?
> 
> Just enable
> 	-DELF_IMAGE
> 	-DAOUT_IMAGE
> 	-DIMAGE_FREEBSD
> 	-DFREEBSD_KERNEL_ENV

> Might be usefull to define a build target that turns all options
> on.  If building on FreeBSD the Makefile turns these on the basic
> FreeBSD support automatically.

I will check it out.  At least with the FreeBSD pxe code someone
contributed it depended on headers that are only present on FreeBSD.
And that code at least is broken in 5.1.x
 
> BTW several FreeBSD users use these options with rom-a-matic to build
> FreeBSD boot roms.  So it really doesn't matter what system compiles
> Etherboot.

Cool.  So except for that one weird case it should not be a problem.
For anything in the etherboot core (not helper utilies) etherboot
should not depend on anyones system header files.  I would have a good
suggestion for nrv2b except that is a helper utility.

It is nice to know that FreeBSD still works with etherboot.  It would
be nice if etherboot did not need FreeBSD specific code but that is
another issue.  Do you know if there is any interest in running
FreeBSD under LinuxBIOS?

Eric