[Etherboot-developers] last call for 5.0.7 check-ins
Brought to you by:
marty_connor,
stefanhajnoczi
|
From: <ke...@us...> - 2002-07-26 07:48:21
|
Please check-in any anticipated 5.0.7 material by this weekend, or it won't be included in the release. Thanks. Timothy, does it hurt if ISA_PNP is always defined when compiling 3c515.c? I.e. are BIOS detection and driver detection mutually exclusive? If not you could add it to 3C515FLAGS and it will be used when compiling that file. If yes, perhaps in 5.0.8, the code could check if BIOS detection has been done and if not, do its own detection. Generally I would like to keep the number of #define options down. #ifdefs make code less readable and increase the number of combinations of code that have to be tested. If something can be detected automatically, do it that way, even if it means a little more code. If always having the extra functionality without any ill-effects costs only a few bytes, do it that way. If options can be grouped into fewer ones or turning on one option implies another, do it that way. At some point I guess I should review the options for 5.1 to see if they can be trimmed down. |