[Etherboot-developers] bug report: USRPARMS only works for alpha menu items

[Ben L. <be...@ti...>]

I specified SHOW_NUMERIC for my etherboot 5.0.6 images - and thus
discovered a bug in the modifier parameter handling: bootmenu.c
says, in selectImage():

		if ((i >= 'A') && (i < 'A'+m)) {
			i -= 'A';
#ifdef	USRPARMS
			modifier_keys |= 3; /* ShiftL + ShiftR */
#endif
			break;
		} else if ((i >= 'a') && (i < 'a'+m)) {
			i -= 'a';
			break;
		} else if ((i >= '1') && (i < '1'+m)) {
			i -= '1';
			break;
		}

Which doesn't account for <shift>-numeric menu items. i.e. pressing
<shift>-<a> presents the Params: prompt; pressing <shift>-<1> does not
(though pressing <shift>-<somekey), then <1> works ok).

Regards,

-- 
Ben Low
"Everywhere I go I'm asked if I think the university stifles
writers. My opinion is that they don't stifle enough of them."
	- Flannery O'Connor (1925-1964)