Re: [Etherboot-developers] [PATCH] PCI updates to avoid e1000 chaos

[Christopher Li <ch...@gn...>]

Yes, those are good changes. And it allow to use the address
otherthan the base address 0.

I just find out that line is come from the old driver template I base
on, but I happen to have some change (similar to yours, I try to change
the base address) conflict your change and this line caught my
eye. It is nothing to do with your change in deed.

Sorry for the confustion.

Chris

On 13 Mar 2002, Eric W. Biederman wrote:
> 
> O.k. Let me clarify a little what I did.  The current
> etherboot values of pcidev->membase && pcidev->iobase are
> bogus concepts from a generic pci perspective.  In generic pci 
> you have 6 base registers that can either be io or memory mapped
> io addresses.
> 
> So I still compute pcidev->membase && pcidev->iobase for backwards
> compatibility but I have depricated their use for new things.  
> For the e1000 I slightly modified it to read the value of
> PCI_BASE_ADDRESS_0 directly.
> 
> Aditionally the generic etherboot code no longer makes checks to 
> see if the any of the pci resources are populated.
> 
> So from a pci device perspective this is the general solution that
> works for everything.
> 
> Eric
> 
> _______________________________________________
> Etherboot-developers mailing list
> Eth...@li...
> https://lists.sourceforge.net/lists/listinfo/etherboot-developers
>