Re: [Etherboot-developers] EEPRO100.C PCI activiation

[<ebi...@ln...>]

Christoph Plattner <chr...@al...> writes:

> Hello Etherboot Hackers !
> 
> Have a look at eepro100.c in the eepro100_probe():
> 
> 
>         /* From Matt Hortman <mbh...@ac...> */
>         if (p->dev_id == PCI_DEVICE_ID_INTEL_82557 ) {
>                 /*
>                 * check to make sure the bios properly set the
>                 * 82557 (or 82558) to be bus master
>                 *
>                 * from eepro100.c in 2.2.9 kernel source
>                 */
> 
> 		code
> 		code
>         }
> 
> 
> Why is this code only done for 82775 and not all derivates.

Because it was initialially coded that way.  There is no good reason
for it.

> Should there not be all chips of the familiy in the "if" ?

yes.

> An interesting thing: We are working on a prototype version
> of a new built hardware using the i82559ER. On prototype A
> the NIC works, on protoype B, the problem occurs. So there
> is a depenceny on BIOS and hardware mapping of addresses, etc...

It is a BIOS dependency.  And removing the if should remove that
dependency.  Though after I ported this code to the 3com series
nics that this should really be a generic routine like the 2.4
pci_set_master() that gets called instead of nic dependant code.

Eric