Re: [Etherboot-developers] MAX_BOOTP_EXTLEN in Etherboot 5.0.3

[Ian D. <ie...@ma...>]

In message <200...@ke...>, ke...@us...
.net writes:
>>However, it would be nicer to just interpret RFC2132 in the way that
>>is most likely to work with all servers :-)
>
>But then there would be no incentive to fix bugs. :-)

True - but the problem is more the ambiguity of the RFC and the
fact that there are broken bootp servers out there. FreeBSD's bootpd
is fixed now, but I still think that Etherboot should choose the
most conservative interpretation of an ambiguous definition... How
about something like this:

	/* Bah, RFC2132 is ambiguous about the size to which the "Maximum
	 * DHCP Message size" refers. It almost certainly means the MTU,
	 * but choose our maximum conservatively in case the server
	 * interprets it as a maximum UDP payload length. */
	#define MAX_BOOTP_MSGLEN	(ETH_MAX_MTU-sizeof(struct iphdr) \
					 -sizeof(struct udphdr))

However, it's not a problem for me any more so I'll leave you and
the rest of the mailing list in peace :-) Thanks for the quick
responses to my questions!

Ian