Re: [Etherboot-developers] rtl8139 TX timeout solved (for me)

[<ebi...@ln...>]

ebi...@ln... (Eric W. Biederman) writes:

> Marty Connor <md...@th...> writes:
> 
> > On 9/4/2001 4:59 PM Eric W. Biederman ebi...@ln... wrote:
> > >Given that we need this for both linuxBIOS and some of the more different 
> > >BIOS's I suspect we should create some helper functions like 
> > >pci_enable_device and pci_set_master (examples from the linux kernel api) 
> > >and use these in all of the pci networking drivers. 
> > >Marty, Ken what do you think?
> > 
> > I think this would be a good idea.  There is inconsistency in how drivers 
> > handle PCI initialization, and I think it should probably be done before 
> > the call to eth_reset, so that the driver doesn't have to deal with it.  
> > This shouldn't increase code size, and would likely fix some BIOS 
> > incompatibility bugs.
> 
> Hmm.  Code size is an issue...  
> 
> My gut reaction is not to make this common, and just to insert helper
> functions calls.  The reason is that pci devices while they tend to
> be fairly standard, they are not always so.  Leaving this logic to the 
> device driver sounds a little more reasonable to me.  I don't
> think etherboot supports any unreasonable hardware at the moment.

And I forgot to say.  If you code it I really don't care how it is dealt
with, unless I'm the project maintainer.  If I code it I'll write it my way :)

Eric