Re: [Etherboot-developers] Re: [Etherboot-users] RTL8139 EEPROM (SOLVED)

[Ken Y. <ke...@nl...>]

>Incidentally, while I was checking all sorts of things,  I found a couple of
>small things in the driver that didn't look right.  I'll mention them here in
>case they may be important to someone, but since everything works ok as it is
> I
>wouldn't worry about them otherwise.  (These comments apply to rtl8139.c in
>Etherboot 4.7.20, please ignore if they have already been fixed).
>
>1.  The write to Config1 (register offset 0x52)  in rtl8139_probe() under the
>comment "Bring the chip out of low-power mode" probably is not having any eff
>ect
>since bits EEM1-0 in Cfg9346 (register offset 0x50) need to be set first to
>unlock the Config1 register for write.
>
>2.  The MultiIntr register (offset 0x5C) should be cleared, according to the
>RTL8139C data sheet.
>
>
>One other thing.  I needed to reset the chip in rtl_disable(), which original
>ly
>was empty.  Without doing this I got "Unable to handle kernel paging request"
>panics when booting Linux after Etherboot.  I had USE_INTERNAL_BUFFER defined
>.
>The following code (just copied from elsewhere in the driver) worked for me:
>
>static void rtl_disable(struct nic *nic)
>{
>...
>}

Thanks for that. I'll add the disable routine in. Can some RTL8139
expert comment on the other two fixes?