Thread: [Etherboot-developers] typo
Brought to you by:
marty_connor,
stefanhajnoczi
Menu
▾
▴
etherboot-developers
|
From: Adam S. <ad...@cf...> - 2002-11-12 13:36:19
|
[not on list, cc] Index: etherboot-5.1/src/ide_disk.c =================================================================== RCS file: /cvsroot/etherboot/etherboot/etherboot-5.1/src/ide_disk.c,v retrieving revision 1.5 diff -u -u -r1.5 ide_disk.c --- etherboot-5.1/src/ide_disk.c 8 Oct 2002 23:15:35 -0000 1.5 +++ etherboot-5.1/src/ide_disk.c 12 Nov 2002 13:27:29 -0000 @@ -176,7 +176,7 @@ /* IDE_CMD_SET_FEATURE sub commands */ #define IDE_FEATURE_CFA_ENABLE_8BIT_PIO 0x01 #define IDE_FEATURE_ENABLE_WRITE_CACHE 0x02 -#define IDE_FEATURE_SET_TRANSFRE_MODE 0x03 +#define IDE_FEATURE_SET_TRANSFER_MODE 0x03 #define IDE_FEATURE_ENABLE_POWER_MANAGEMENT 0x05 #define IDE_FEATURE_ENABLE_POWERUP_IN_STANDBY 0x06 #define IDE_FEATURE_STANDBY_SPINUP_DRIVE 0x07 ===================================================================== -- Adam http://www.eax.com The Supreme Headquarters of the 32 bit registers |
|
From: Adam S. <ad...@cf...> - 2002-11-12 15:08:23
|
[not on list, cc]
========================================================================
more typos
---------------------------------
Adam Sulmicki <ad...@cf...>
Tue Nov 12 08:14:16 EST 2002
http://www.eax.com/patches/
-------------------------------------------------------------------------------
Index: etherboot-5.1/src/ide_disk.c
===================================================================
RCS file: /cvsroot/etherboot/etherboot/etherboot-5.1/src/ide_disk.c,v
retrieving revision 1.6
diff -u -u -r1.6 ide_disk.c
--- etherboot-5.1/src/ide_disk.c 12 Nov 2002 13:50:40 -0000 1.6
+++ etherboot-5.1/src/ide_disk.c 12 Nov 2002 15:05:30 -0000
@@ -580,7 +580,7 @@
if ((sizeof(sector_t) < sizeof(uint64_t)) &&
drive_info[103] || drive_info[102]) {
/* FIXME use a 64bit sector number */
- printf("Drive to big\n");
+ printf("Drive too big\n");
return -1;
}
info->sectors =
@@ -638,7 +638,7 @@
/* Put the drives ide channel in a know state and wait
* for the drives to spinup.
*
- * In practice IDE disks to not respond to commands until
+ * In practice IDE disks tend not to respond to commands until
* they have spun up. This makes IDE hard to deal with
* immediately after power up, as the delays can be quite
* long, so we must be very careful here.
@@ -652,7 +652,7 @@
* BSY_SET_DURING_SPINUP to 0.
*
* - The BSY bit floats high when no drives are plugged in.
- * This case will not be deteced except by timeing out but
+ * This case will not be deteced except by timing out but
* we avoid the problems by only probing devices we are
* supposed to boot from. If we don't do the probe we
* will not experience the problem.
@@ -677,7 +677,7 @@
*
* For now I will go with just sending commands to the drives
* and assuming filtering out missing drives by detecting registers
- * that won't set and, commands that fail to execute properly.
+ * that won't set and commands that fail to execute properly.
*/
/* Now initialize the individual drives */
========================================================================
--
Adam
http://www.eax.com The Supreme Headquarters of the 32 bit registers
|
|
From: Donald J C. <dj...@ci...> - 2002-11-12 19:17:02
|
Adam Sulmicki wrote:
> [not on list, cc]
>
> ========================================================================
> more typos
...
> - * This case will not be deteced except by timeing out but
> + * This case will not be deteced except by timing out but
^^^
He got one, missed the other one.
-Don
--
Don Christensen Senior Software Development Engineer
dj...@ci... Cisco Systems, Santa Cruz, CA
"It was a new day yesterday, but it's an old day now."
|
|
From: Adam S. <ad...@cf...> - 2002-11-12 21:12:51
|
> > - * This case will not be deteced except by timeing out but > > + * This case will not be deteced except by timing out but > He got one, missed the other one. cool, thanks. Now more practical question. How much use that ide code got in practice? Going over it seems a bit rough on edges and somewhat unfinished. -- Adam http://www.eax.com The Supreme Headquarters of the 32 bit registers |
|
From: <ebi...@ln...> - 2002-11-12 21:20:14
|
Adam Sulmicki <ad...@cf...> writes: > > > - * This case will not be deteced except by timeing out but > > > + * This case will not be deteced except by timing out but > > He got one, missed the other one. > > cool, thanks. > > Now more practical question. How much use that ide code got in > practice? Going over it seems a bit rough on edges and somewhat > unfinished. Well I am using it a few places in production. Except for the spelling errors which don't affect how the code executes there are no outstanding bug reports. It works on compact flash devices, and regular ide disks. It is probably rough simply because it was the first real disk driver for etherboot. The floppy driver is actually much worse. It only seems to work under linuxbios. But the ide disk driver should be generally useful. The only code path I haven't had a chance to test is LBA48 support for very large drives. My current largest drive comes in just under that limit. Eric |
