etherboot-developers

[Etherboot-developers] [PATCH] Marvell Yukon-II "sky2" card support

[Joshua O. <or...@rw...>]

Hi all,

I finally sat down today, armed with my FireWire debug stub, and
attacked the remaining bugs in my sky2 driver port. I'm pretty sure I've
found them all, as I was able to boot my sky2-using MacBook off the
terminal server provided by another machine's Knoppix CD. The boot
process involves a PXE NBP and several TFTP transfers of large files, so
I think it's a pretty robust test.

The attached patch (to git top-of-tree) implements the sky2 driver,
ported from the Linux kernel module of the same name. I think I've done
a reasonable job removing things we don't need, and sky2.lkrn with the
default set of options compiled in is under 64k. The sky2 driver is used
mainly by integrated gigabit Ethernet on several motherboards; I'm only
aware of one removable NIC that uses it, and it's a PCI-E card by
Rosewill. I tested using my MacBook, which is the only piece of
sky2-using hardware I own. NVRAM modifications are not yet supported,
and due to the Mac's architecture I was not able to test a boot from
flash ROM.

More tests with other hardware and boot configurations are of course
welcome. :-)

-- Josh

Re: [Etherboot-developers] [PATCH] Marvell Yukon-II "sky2" card support

[Joshua O. <or...@rw...>]

On Sat, 2009-05-02 at 17:58 -0700, Joshua Oreman wrote:
> The attached patch (to git top-of-tree) implements the sky2 driver,
> ported from the Linux kernel module of the same name. I think I've done
> a reasonable job removing things we don't need, and sky2.lkrn with the
> default set of options compiled in is under 64k.

Following a conversation with meteger earlier today, I've gone through
and removed more things we don't need. I also added some netdev_rx_err()
statements to play more nicely with gPXE's network stack. Net code
savings: 328 bytes. I suppose it's the principle of the thing :-) sky2
is still one of the bigger drivers (~9.4k of code), but it supports a
lot of cards, so I think that's probably OK.

An updated patch against git top-of-tree, and an incremental update to
my previous patch, are both attached.

-- Josh

Re: [Etherboot-developers] [PATCH] Marvell Yukon-II "sky2" card support

[Joshua O. <or...@rw...>]

On Sun, 2009-05-03 at 12:36 -0700, Joshua Oreman wrote:
> An updated patch against git top-of-tree, and an incremental update to
> my previous patch, are both attached.

Oops! I accidentally created the sky2-v2.patch as a diff from the branch
containing my FireWire debugging stuff, instead of from git top-of-tree.
A fixed version is attached, and I apologize for the trouble. The
incremental patch was not affected.

-- Josh

Re: [Etherboot-developers] [PATCH] Marvell Yukon-II "sky2" card support

[Daniel V. <dan...@gm...>]

On Sun, May 3, 2009 at 2:49 PM, Joshua Oreman <or...@rw...> wrote:
> On Sun, 2009-05-03 at 12:36 -0700, Joshua Oreman wrote:
>> An updated patch against git top-of-tree, and an incremental update to
>> my previous patch, are both attached.
>
> Oops! I accidentally created the sky2-v2.patch as a diff from the branch
> containing my FireWire debugging stuff, instead of from git top-of-tree.
> A fixed version is attached, and I apologize for the trouble. The
> incremental patch was not affected.
>
> -- Josh
>

This patch applies (after converting CRLF line endings to LF; maybe
the mailing list is mangling it?) and works for me on an integrated
11ab:4362 device (DFI LanParty DK X48 motherboard).

I haven't looked closely at the patch, but git apply did complain
about some trailing whitespace and other minor nits.

Thanks,
-- Daniel Verkamp