etherboot-developers

Re: [Etherboot-developers] Re: failed

[Ken Y. <ke...@nl...>]

>For Etherboot Developers, in etherboot.h is the following conditional:
>
>#ifdef  IMAGE_MENU
>extern char *motd[RFC1533_VENDOR_NUMOFMOTD];
>...
>
>Is it possible to do MOTD without IMAGE_MENU?  If so, it might make sense 
>to put the *motd buffer under another conditional, or possibly define 
>IMAGEMENU "with extreme prejudice" :-)  

Or I could do this fix, which would forestall this error in future:

Change all #ifdef MOTD to #if defined(MOTD) && defined(IMAGE_MENU).

Re: [Etherboot-developers] Re: failed

[Ken Y. <ke...@nl...>]

>>#ifdef  IMAGE_MENU
>>extern char *motd[RFC1533_VENDOR_NUMOFMOTD];
>>...
>>
>>Is it possible to do MOTD without IMAGE_MENU?  If so, it might make sense 
>>to put the *motd buffer under another conditional, or possibly define 
>>IMAGEMENU "with extreme prejudice" :-)  
>
>Or I could do this fix, which would forestall this error in future:
>
>Change all #ifdef MOTD to #if defined(MOTD) && defined(IMAGE_MENU).

Well it looks like that extern declaration is bracketed by the wrong
ifdef. I've put it inside a #ifdef MOTD now. One more bug fixed for
4.6.11.

Re: [Etherboot-developers] Re: failed

[Marty C. <md...@th...>]

On 11/3/2000 1:23 AM Ken Yap ke...@nl... wrote:
>Or I could do this fix, which would forestall this error in future:
>Change all #ifdef MOTD to #if defined(MOTD) && defined(IMAGE_MENU).

Sounds like a plan.  There are probably other dependencies that should be 
checked as well, and I can probably do a bit more sanity checking in 
rom-o-matic's parameter selection code.  Right now, I allow the user to 
combine options any way they choose, and pass them right to make and let 
it decide, which may in fact be more right than wrong.