Menu

#5 found bug in et131x_tx.c

open
nobody
None
5
2008-05-30
2008-05-30
Anonymous
No

I found a bug in et131x_tx.c while trying to port the driver. On line 241, the offset of the physical address is added to the virtual address, but this result in too large a correction as this is not a byte pointer. Look at et131x_rx.c for the proper way to do it (looks like the bug was caught in one module but not in the other.

The result of this bug is that, for platforms that don't align the allocation on a 4K boundary, that TX is dead.

Discussion


Log in to post a comment.