Re: [ES40-developers] Code formatting

[Camiel V. <iam...@gm...>]

To help track down locking-issues, I've added a standard 2-second
timeout on simple mutex locking operations. I feel that no thread
should ever have to wait more than a few milliseconds to acquire a
lock, so 2 seconds should be safe. Whenever one of the threads runs
into a lock that's being held for more than two seconds, it will fail
with an error message.

That said, unfortunately this won't help with the IDE device's locks,
as these are read/write locks, rather than simple mutexes. I'll see if
I can do this for those locks as well.

Camiel.


On Fri, Mar 14, 2008 at 8:11 PM, Camiel Vanderhoeven
<iam...@gm...> wrote:
> Hello Fausto,
>
>  A frozen system in this case probably means that the CPU is trying to
>  acquire a lock that is held by the IDE device. Could you try to
>  compile the code with HIDE_COUNTER and DEBUG_LOCKS defined to confirm
>  that this is the case?
>
>  Thanks,
>
>  Camiel.
>
>
>
>  On Fri, Mar 14, 2008 at 8:04 PM, Fausto Saporito <fa...@un...> wrote:
>  > Hello Camiel,
>  >
>  >  I just updated the cvs, and the build is fine.
>  >  But I have a new issue with IDE cdrom. I'm using the device (under
>  >  Windows Vista) and when I try to mound a cdrom, I have :
>  >
>  >  %MOUNT-I-WRITELOCK, volume is write locked
>  >
>  >  and the system is freezed.
>  >  On the DOS console the counter still runs, but nothing happens, and I
>  >  don't have error messages.
>  >
>  >  Yesterday, before the latest patch, I had the same problem, but on the
>  >  DOS console I had these error messages (looping on the console):
>  >
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >  CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst:
>  >  ff-ff-ff-ff-ff-ff ..
>  >  src: 00-19-3e-36-70-1b
>  >
>  >  the only thing to do is CTRL-C, and when I do it the quit procedure
>  >  doesn't complete, stopping at
>  >
>  >  Freeing memory in use by system...
>  >   cpu0
>  >
>  >  pressing again CTRL-C, the emulator quits.
>  >
>  >  regards,
>  >  fausto
>  >
>  >
>  >
>  >  Quoting Camiel Vanderhoeven <iam...@gm...>:
>  >
>  >  > Hello Everyone,
>  >  >
>  >  > I've committed a couple of large patches today and yesterday to
>  >  > improve both multithreading and exception handling. This results in
>  >  > restoration of the functionality of the <break>  menu on the serial
>  >  > ports. After these changes, I've run all code through a source code
>  >  > formatter to make the coding style a bit more consistent. I'd like you
>  >  > to check out the new code, and let me know if there are aspects of the
>  >  > source formatting that you don't like. I'm hoping this will improve
>  >  > readibility of the source code, and will help to develop a set of
>  >  > guidelines for coding style.
>  >  >
>  >  > Thanks!
>  >  >
>  >  > Camiel.
>  >  >
>  >  > P.S. I've tagged the repository before committing the re-formatted
>  >  > code; if anything has gone horribly wrong, we can revert...
>  >  >
>  >  > -------------------------------------------------------------------------
>  >  > This SF.net email is sponsored by: Microsoft
>  >  > Defy all challenges. Microsoft(R) Visual Studio 2008.
>  >  > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>  >  > _______________________________________________
>  >  > Es40-developers mailing list
>  >  > Es4...@li...
>  >  > https://lists.sourceforge.net/lists/listinfo/es40-developers
>  >  >
>  >
>  >
>  >
>  >  -------------------------------------------------------------------------
>  >  This SF.net email is sponsored by: Microsoft
>  >  Defy all challenges. Microsoft(R) Visual Studio 2008.
>  >  http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>  >  _______________________________________________
>  >  Es40-developers mailing list
>  >  Es4...@li...
>  >  https://lists.sourceforge.net/lists/listinfo/es40-developers
>  >
>