Menu

#8 Long Method in ClientCommDummy()

1.0
closed
None
2016-03-28
2016-03-24
No

Code smell: Long Method
Location: ClientCommDummy.connect(String serverAddress, String nickname)
Rationale: One of the Long Methods in the ClientCommDummy class, but i think one of the most important to be simples and small. This method should be smaller and with less responsabilitie.

Discussion

  • Nuno Miguel Ferreira Pireza

    extract method has been used to create connectivity_process(serverAdress) and output_message(messageSent).
    Also the new class ClientConnectedServerSideMessage(null, nickname) created in commit r8 made the method simplier.
    With r8 and r14 commits this ticket is considered closed.

     

    Last edit: Nuno Miguel Ferreira Pireza 2016-03-28
  • Nuno Miguel Ferreira Pireza

    • status: open --> closed
     
  • Nuno Miguel Ferreira Pireza

    • assigned_to: Nuno Miguel Ferreira Pireza
     

Log in to post a comment.