Menu ▾ ▴

#5 type checking in birdsong.dummy.BirdSongClientMessageReceiver.run()

1.0
closed
Filipe Fernandes
None
2016-03-25
2016-03-23
Filipe Fernandes
No

Code smell: type checking
Location: birdsong.dummy.BirdSongClientMessageReceiver.run()
Rationale: The Switch statement checks for types of message. One can use polymorphism to improve code readability this reducing the size of the method.

Discussion

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-25
    • status: open --> closed
    • assigned_to: Filipe Fernandes
     

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-25

    ClientSideMessageDummy is now abstract and one class for each type of message has been created.

     

Log in to post a comment.