Menu

#3 Duplicated Code in BirdSongClientMessageReceiver.run()

1.0
closed
None
2016-03-25
2016-03-23
No

Code smell: Duplicated Code
Location: BirdSongClientMessageReceiver.run()
Rationale: The condition above is repeated in every case on the switch, to assure a breakline is made. We should unify them to simplify the code.

Discussion

  • Nuno Miguel Ferreira Pireza

    • assigned_to: Nuno Miguel Ferreira Pireza
     
  • Nuno Miguel Ferreira Pireza

    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +0,0 @@
    -Duplicated_Code.JPG (42.6 kB; image/jpeg)
    
     
  • Nuno Miguel Ferreira Pireza

     
  • Nuno Miguel Ferreira Pireza

    • assigned_to: Nuno Miguel Ferreira Pireza --> nobody
     
  • Filipe Fernandes

    • status: open --> closed
    • assigned_to: Filipe Fernandes
     
  • Filipe Fernandes

    Extract local variable has been used to solve this ticket.

     

Log in to post a comment.