Menu ▾ ▴

#1 God Class in birdsong.dummy.BirdSongClientDummy

1.0
closed
Nuno Miguel Ferreira Pireza
None
2016-03-28
2016-03-23
Filipe Fernandes
No

Code smell: God Class
Location: birdsong.dummy.BirdSongClientDummy
Rationale: When a class is considered a God Class its maintenance is almost impossible. Using Extract Class to remove the JFrame instatiation from BirdSongClienteDummy, one is able to improve code readbility and increase maintability.

Discussion

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,3 @@
 Code smell: God Class
 Location: birdsong.dummy.BirdSongClientDummy
-Rationale: When a class is considered a God Class it's maintenance is almost impossible. Using Extract Class, one is able to improve code readbility and increase maintability. 
+Rationale: When a class is considered a God Class its maintenance is almost impossible. Using Extract Class, one is able to improve code readbility and increase maintability.
     

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-23

    typo

     

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,3 @@
 Code smell: God Class
 Location: birdsong.dummy.BirdSongClientDummy
-Rationale: When a class is considered a God Class its maintenance is almost impossible. Using Extract Class, one is able to improve code readbility and increase maintability. 
+Rationale: When a class is considered a God Class its maintenance is almost impossible. Using Extract Class to remove the JFrame instatiation from BirdSongClienteDummy, one is able to improve code readbility and increase maintability.
     

  • Filipe Fernandes

    Filipe Fernandes - 2016-03-23

    clarity

     

  • Nuno Miguel Ferreira Pireza

    Nuno Miguel Ferreira Pireza - 2016-03-28

    Ticket solved with commit r15.
    It has been created a class named BirdsongClientDummyMenuBarFrames and moved to it methods openFollowWindow(), openUnfollowWindow() and openAboutWindow() .
    All funcionalities from the menu bar.

     

  • Nuno Miguel Ferreira Pireza

    Nuno Miguel Ferreira Pireza - 2016-03-28
    • status: open --> closed
    • assigned_to: Nuno Miguel Ferreira Pireza
     

Log in to post a comment.