Just a quick notice to tell you that I have commited my rev_proxy changes.
I still did not made the extensive changes that Klacke suggested last
week, but I am still planning to do some more refactoring in the code.
However, it should work better now. If you still encounter problem, I am
willing to solve them so do not hesitate to submit any encountered problems.
My changes required a modification in the reformat_header function in
the yaws_api module.
The #headers.cookie value was tested against the atom undefined, but the
default value is an empty list. This causes the "Cookie: " header to be
added in all cases, even when no cookie was specified.
Klacke, could you, please, have a look at it to check that this is correct ?
I think so, but as the change does not only impact proxying it is better
to check twice.
By default, the code was working with keep-alive enabled, but it caused
me some troubles with existing application running over HTTP. I have
started implemented keep-alive and non keep-alive support, but I need
feedback regarding an option I am planning to add:
I think we need to be able to completly disable keep-alive for the proxy
for dealing with cases where it causes troubles. I am thinking of adding
a config file option to disable keep-alive.
What do you think of adding an option such as:
revproxy_keepalive = true | false
to be able to disable keepalive (true being the default) ?
Thank you in advance for your feedback.