Re: [Erlyaws-list] SSL multipart POST makes Yaws server crash

[Christopher F. <chr...@ca...>]

On 01/10/2012 18:54, Jean-Charles Campagne wrote:
> I came across a little bug while trying to upload an image file to a
> Yaws server when using HTTPS/SSL connection. When the file was large
> enough (under a few megs), the server would crash (See end of mail for
> error log excerpt).
> 
> I am quite new to Yaws, so I hope I did not misunderstand some of the
> workings there ;-) I tried to narrow it down and I have put up a test
> case that makes the server crash, and a possible workaround here
> (ssl_multipart_bug branch):

[...]

> 
> I am calling this snippet of code a "workaround" more than a fix because
> I am not sure it is the most elegant way to do it :-) I've put it in a
> function called 'yaws_server:unwrap_clisock/1' just to make it more obvious.
>

Hi Jean-Charles,

I confirm the bug. Your patch fixes chunked uploads but, by making a
quick code review, I found the same bug in some other functions. So this
problem must be handled in a slightly different way. however, your
testcase can be kept as it is.

I pushed my changes in the branch fix-ssl-socket-wrapping[1][2], feel
free to test it. As Klacke said, Steve worked on the SSL socket wrapping
few month ago. So we will wait for his feedback before moving forward.

Thank you for your contribution!
-- 
Christopher

[1] https://github.com/klacke/yaws/tree/fix-ssl-socket-wrapping
[2] https://github.com/klacke/yaws/commit/6e6e24d7