From: Steve V. <vi...@ie...> - 2010-07-21 01:49:34
|
On Tue, Jul 20, 2010 at 12:23 PM, Steve Vinoski <vi...@ie...> wrote: > On Mon, Jul 19, 2010 at 4:45 PM, Hans-Christian Esperer > <hc...@hc...> wrote: >> On Mon, Jul 19, 2010 at 02:57:03PM -0400, Steve Vinoski wrote: >>> On Mon, Jul 19, 2010 at 12:39 PM, Hans-Christian Esperer >> [...] >>> Thanks! I took a quick look and it looks straightforward, so I'll try >>> to push it to github later today or early tomorrow. >> >> Cool. :) >> >> I forgot to add an entry to the manual page for the configuration >> option. Attached to this email. > > This is helpful, thanks very much. I'm also adding some documentation > to the Yaws PDF file, so once I get that completed, I'll push it to > github. OK, I've pushed the patch, though slightly modified and mixed with some other related changes. For example, in yaws_config.erl with the original patch applied there were now two routines for parsing host:port strings, so I took the opportunity to refactor some of the existing FCGI code to use the new code instead. Also, the existing FCGI code used separate #sconf fields for host and port, which I thought was overkill, so I modified it to use a single field storing a {host,port} tuple instead and made the new PHP FCGI code follow suit. In addition to the man page additions included in the patch, I also added new documentation to the yaws.tex file. I also fixed up a number of little editorial issues in that file. Hans-Christian, thanks again for the contribution, we appreciate it. --steve |