From: Erik P. <er...@at...> - 2003-02-07 10:21:51
|
I like yaws, and am using it more and more. The compact size is great, making it easy to experiment with it. But, I do have a bit more comments. 0. There's the atom 'trueeeeeeeeeeeeeee' in yaws_server.erl. Didn't know if it was supposed to be 'true'. 1. I can't find a way to turn off directory browsing. Perhaps I'm missing something. You can go to URLs like: http://yaws.hyber.org/icons/ et al. This would probably be like adding another binary field to the server record. 2. If directory browsing is allowed, it seems it would be better in yaws_ls:doc_head() to give the requested URL, not the expanded path of the directory. Righ now I think it tells too much of the underlying file structure. From above, you will see the absolute path of /var/yaws/www//icons. 3. Going thru the directory listing, I noticed I could try: http://yaws.hyber.org/icons/?N=D so I tried removing the last "/". http://yaws.hyber.org/icons?N=D I don't know all the legalities of URLs from the RFC, but something wasn't happy..... Eventually I reached some redirect limit error from the server. Again, I hope this helps! --erikp-- |
From: Claes W. <kl...@hy...> - 2003-02-08 12:40:11
|
On Fri, Feb 07, 2003 at 02:27:57AM -0800, Erik Pearson wrote: > I like yaws, and am using it more and more. > The compact size is great, making it easy to > experiment with it. But, I do have a bit > more comments. > > 0. There's the atom 'trueeeeeeeeeeeeeee' in yaws_server.erl. > Didn't know if it was supposed to be 'true'. > This is nothing really. It's just dead code and the trueeeeeeeeeeeeeee is on purpose. It's the check_header code that hasn't been properly updated since the last major rewrite of the header handling. No worries. > 1. I can't find a way to turn off directory browsing. Perhaps > I'm missing something. You can go to URLs like: > > http://yaws.hyber.org/icons/ et al. > There is currently no way to turn that off. It's easily fixed. - Add an item for this is #sconf - fix the config parser yaws_config.erl to handle this - fix the yaws_server:handle_ut to check this field and maybe not call yaws_ls:....... > > 2. If directory browsing is allowed, it seems it would be better > in yaws_ls:doc_head() to give the requested URL, not the expanded > path of the directory. Righ now I think it tells too much of the > underlying file structure. > > From above, you will see the absolute path of /var/yaws/www//icons. > I completely agree. > 3. Going thru the directory listing, I noticed I could try: > > http://yaws.hyber.org/icons/?N=D > > so I tried removing the last "/". > > http://yaws.hyber.org/icons?N=D > Bug. > I don't know all the legalities of URLs from the RFC, > but something wasn't happy..... Eventually I reached > some redirect limit error from the server. > > Again, I hope this helps! > The above URL is indeed ok. A bit weird, but ok. In our case it should render a redirect to {redirect, "http://yaws.hyber.org/icons/?N=D"} But it gives us a redir to: http://yaws.hyber.org/icons?N=D/ which is super wrong. I'll fix that as well. Thanks. -- Claes Wikstrom -- Caps lock is nowhere and http://www.hyber.org -- everything is under control |