[Erc-help] [PATCH] erc: define-erc-response-handler (JOIN) to save-excursion

[Adrian A. <ad...@xe...>]

Hi erclings!

The missing save-excursion is the cause of (erc-current-logfile)
inserting into the wrong channel buffers when using
erc-log-insert-log-on-open in combination with autojoin to multiple
channels.

I'll commit later today if noone catches a flaw with this patch.

My own testing went well.

Best regards,

Adrian

ChangeLog addition:

2005-04-24  Adrian Aichner  <ad...@xe...>

	* erc-backend.el (JOIN): save-excursion so that
	`erc-current-logfile' inserts into the correct channel buffers
	when using erc-log-insert-log-on-open in combination with autojoin
	to multiple channels.


erc source patch:
Diff command:   cvs -f -z3 -q diff -u -w -N
Files affected: erc-backend.el erc-backend.el

Index: erc-backend.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-backend.el,v
retrieving revision 1.27
diff -u -w -r1.27 erc-backend.el
--- erc-backend.el	4 Apr 2005 16:38:11 -0000	1.27
+++ erc-backend.el	24 Apr 2005 16:36:31 -0000
@@ -452,6 +452,7 @@
       ;; strip the stupid combined JOIN facility (IRC 2.9)
       (if (string-match "^\\(.*\\)?\^g.*$" chnl)
           (setq chnl (match-string 1 chnl)))
+      (save-excursion
       (let* ((str (cond
                    ;; If I have joined a channel
                    ((erc-current-nick-p nick)
@@ -478,7 +479,7 @@
         (erc-update-channel-member chnl nick nick t nil nil host login)
         ;; on join, we want to stay in the new channel buffer
         ;;(set-buffer ob)
-	(erc-display-message parsed nil buffer str)))))
+	  (erc-display-message parsed nil buffer str))))))
 
 (define-erc-response-handler (KICK)
   "Handle kick messages received from the server." nil

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/