Re: [Erc-help] Re: making erc-hide-list apply to all messages

[Henrik E. <hen...@te...>]

Lawrence Mitchell <we...@gm...> writes:

> Henrik Enberg wrote:
>
>> Currently, erc-hide-list is only checked in the message handlers of a
>> small subset[1] of all possible messages.  It'd be nice to be able to
>> hide any message without having to resort to erc-insert-this and funky
>> regexps.
>
>> The attached patch moves the check to erc-display-message and removes
>> the checks from the handlers in erc-backend.el
>
>> [1] JOIN, KICK, MODE, NICK, PART, QUIT and TOPIC
>
> This looks fine to me, apart from the one comment below.
>
> [...]
>
>>  See also `erc-format-message' and `erc-display-line'."
>>+  (unless (and (arrayp parsed)
>                  ^^^^^^^
> This ought to be `erc-response-p' I guess.

The patch is still wrong, unfortunately.  sometimes erc-display-message
is legitimately called with a nil PARSED arg.  A revised patch that
handles this is attached.