[Erc-help] Re: [PATCH] erc: Avoid define-erc-response-handler miscompile with eval-when-compile wrapper

[Adrian A. <Adr...@t-...>]

"Adrian Aichner" <Adr...@t-...> writes:

> Hi fellow erclings!
>
> Would this XEmacs compatibility patch be agreeable?
>
> I can commit if desired.
>
> Please advise,
>
> Adrian
>
> ChangeLog addition:
>
> 2005-01-17  Adrian Aichner  <ad...@xe...>
>
> 	* erc-backend.el: Avoid miscompile with eval-when-compile wrapper.

Ah, meant to include the original XEmacs startup error message:

Error in init file: Symbol's value as variable is void: define-erc-response-handler
Requiring erc-compat...done (file erc-compat.elc does not exist)
Loading timezone...done
Loading timezone...
Loading easy-mmode...done
Loading easy-mmode...
Requiring erc-compat... (file erc-compat.elc does not exist)
Paren mode is sexp
Loading paren...done
Loading paren...

Adrian

>
>
> erc source patch:
> Diff command:   cvs -f -z3 -q diff -u -w -N
> Files affected: erc-backend.el
>
> Index: erc-backend.el
> ===================================================================
> RCS file: /cvsroot/erc/erc/erc-backend.el,v
> retrieving revision 1.19
> diff -u -w -r1.19 erc-backend.el
> --- erc-backend.el	12 Jan 2005 17:11:57 -0000	1.19
> +++ erc-backend.el	17 Jan 2005 22:00:17 -0000
> @@ -244,12 +244,14 @@
>  		      (mapconcat 'identity (erc-response.command-args parsed) " "))))
>      (erc-display-message parsed 'notice proc line)))
>  
> +;;; XEmacs change: Require edebug at compile time.
> +(eval-when-compile
>  (when (condition-case nil (require 'edebug) (error nil))
>    (def-edebug-spec define-erc-response-handler
>      (&define :name erc-response-handler
>               (name &rest name)
>               &optional sexp sexp
> -             def-body)))
> +               def-body))))
>  
>  (defmacro* define-erc-response-handler ((name &rest aliases)
>                                          &optional extra-fn-doc extra-var-doc

-- 
  Adrian Aichner              Teradyne GmbH, European Design Center
  Consumer Business Unit      Telephone +49/89/41861(0)-208
  Dingolfinger Strasse 2      Fax       +49/89/41861-115
  D-81673 MUENCHEN            E-mail    adr...@te...