[Erc-help] Re: ERC logging bug

[Hoan Ton-T. <ho...@to...>]

Adrian Aichner <ad...@xe...> writes:

> Hoan Ton-That <ho...@to...> writes:
>
>> Hello,
>>
>> If `erc-log-channels-directory' is set to a directory which contains
>> uppercase characters then logging will not work.  The function
>> `erc-current-logfile' downcases everything including the directory
>> part.  The following simple patch fixes this bug.
>
> Hello Hoan, that explains the first hunk of your patch.
>
> Why are you throwing out all these occurences of expand-file-name in
> other functions which produce file paths based on
> erc-log-channels-directory ?
>

Suppose that `erc-generate-log-file-name-function' is set to
`erc-generate-log-file-name-short' and that function is defines as
before.  Then if `erc-current-logfile' is called on any buffer,
`erc-generate-log-file-name-short' will generate a fully expanded
pathname.  This pathname will be downcased, which includes the
directory.  Therefore those generation functions should not expand the
filename.  The expansion takes place in `erc-current-logfile'.