From: Brian P. <bp...@re...> - 2004-12-11 09:39:32
|
I got a bug report about having to do a /ctcp nick VERSION instead of /ctcp nick version (and similar). Apparently other clients (such as bitchx) automatically upcase the ctcp command. It's not clear to me that is a technically correct thing to do, looking at the various specs on irchelp, but it certainly strikes me as more convention, and the likelihood that someone would expect 'version' to do something other than 'VERSION' strikes me as low. I'm proposing the below patch. Feedback would be welcome; otherwise I'll commmit it soon. Index: erc.el =================================================================== RCS file: /cvsroot/erc/erc/erc.el,v retrieving revision 1.705 diff -r1.705 erc.el < (cond < (tgt < (erc-log (format "erc-send-CTCP-notice: [%s] %s" tgt l)) < (erc-send-command (format "NOTICE %s :\C-a%s\C-a" tgt l) force)))) --- > (let ((l (upcase l))) > (cond > (tgt > (erc-log (format "erc-send-CTCP-notice: [%s] %s" tgt l)) > (erc-send-command (format "NOTICE %s :\C-a%s\C-a" tgt l) force))))) -- I'm awfully glad I'm a Beta, because I don't work so hard. |