[Erc-help] Re: [PATCH] (erc-process-sentinel): add customizable option to close server buffers automatically, code cleanup

[Lawrence M. <we...@gm...>]

Brian Palmer wrote:

[...]

> One thing I noticed when looking over the patch, is there a reason why
> the erc-kill-*-on-* variables are only defcustomizable, but not
> set-variable--able?

> that is, they're defined with something like

> (defcustom erc-kill-queries-on-quit nil
>   "Kill all query (also channel) buffers of this server on QUIT.
> See the variable `erc-kill-buffer-on-part' for details."
>> group 'erc
>> type 'boolean)

> without an initial * in the docstring.

Probably an oversight.  You might want to add something to
HACKING to the effect that variables that are intended to be
user-changed should have an inital * in the docstring.  I
/believe/ there was some discussion about emacs for making all
defcustom'ed variables also set-variable-able.  However, I don't
think set-variable uses the same mechanism, (i.e. not using the
custom :set form if it exists), and so nothing came of it.

Either way, from what I can recall (no recourse to ERC sources
here), I don't think we religiously follow the defcustom is
user-changable rule.  So that might be something worth looking at.

-- 
Lawrence Mitchell <we...@gm...>