Re: [Erc-help] Re: [PATCH] (erc-process-sentinel): add customizable option to close server buffers automatically, code cleanup

[Brian P. <bp...@re...>]

Michael Olson <mw...@me...> writes:

> On Thu, 15 Jul 2004 13:11:53 +0100, lawrence mitchell wrote:

> > That way you don't have to worry about the dodgy behaviour of
> > beginning-of-line with invisible/intangible stuff, and you don't
> > add the prompt to the kill ring, which would definitely not be
> > expected by the user.
> 
> You're right.  The included patch incorporates this change.  Also: I
> forgot to remove the comment about XEmacs; as far as I know, this
> method works just as well for XEmacs as with GNU Emacs.
 
Committed. Comments welcome. 

One thing I noticed when looking over the patch, is there a reason why
the erc-kill-*-on-* variables are only defcustomizable, but not
set-variable--able?

that is, they're defined with something like 

(defcustom erc-kill-queries-on-quit nil
  "Kill all query (also channel) buffers of this server on QUIT.
See the variable `erc-kill-buffer-on-part' for details."
  :group 'erc
  :type 'boolean)

without an initial * in the docstring. 

-- 
I'm awfully glad I'm a Beta, because I don't work so hard.