Re: [Erc-help] [PATCH] Change how erc-select gets its arguments

[Brian P. <bp...@re...>]

Brian Palmer <bp...@re...> writes:

> Currently erc-select is a interactive function which doesn't actually
> set any of its arguments from the (interactive) form; instead, in the
> main body of the function, it calls read-from-minibuffer several times
> to get important information from the user. Some of this information
> is stored in separate history lists, but other information (such as
> the port number) is let into the general minibuffer history. 

I've committed this (well, with some minor changes). If you're using
erc-select interactively, there should be few visible differences. 

1. [username@]server[:port] if typed at the server question will cause
it to skip some of the subsequent questions. The prompt has not
changed, however, to indicate this.
2. the port will now use the value of erc-port, if set, to provide a
default instead of the old way of hardcoding "ircd" as the default
port.

If used non-interactively, erc-select now does not read from the
minibuffer. Instead, it uses keyword arguments and default values 

(defun* erc-select (&key (server erc-server) (port erc-port) (nick
erc-nick) password (full-name erc-user-full-name))

to get arguments to send to erc. Since erc was basically unusable
non-interactively before, I expect this situation is the best time to
make incompatible changes for non-interactive. (Note that the previous
version I had sent for comment used only &optional arguments). 

Comments welcome. 

-- 
I'm awfully glad I'm a Beta, because I don't work so hard.