[Erc-help] Re: [patch] erc-scroll-to-bottom fails if erc-insert-marker is nil

[Lawrence M. <we...@gm...>]

Jari Aalto wrote:

> I'm sending thri patch here, as nobody seemed to have read the
> Sourceforge patch page. The scroll to bottom function dies, if
> erc-insert-marker is nil.

>    (if (and window (window-live-p window))
>+      ;;  If there is no value, nothing we can do
>+      erc-insert-marker

I think you mean:

(if (and window (window-live-p window) erc-insert-marker) ...)

yes?


I think `erc-insert-marker' being nil when
`erc-scroll-to-bottom' is called is probably indicative of a
more fundamental bug.  I can't think of any point at which
`erc-scroll-to-bottom' should be called without
`erc-insert-marker' being initialised.

Can you provide a repeatable test case for the problem?

[...]

-- 
Lawrence Mitchell <we...@gm...>