|
From: lawrence m. <we...@gm...> - 2003-10-14 16:09:41
|
DEFINE-ERC-MODULE seems to incorrectly not set erc-foo-mode in
erc-foo-enable and erc-foo-disable. This leads to incorrect
results if one does, say, erc-foo-enable, and then erc-foo-mode,
hoping to turn foo-mode off.
Unless anyone has any objections, I'll apply this patch:
Index: erc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc.el,v
retrieving revision 1.573
diff -u -r1.573 erc.el
--- erc.el 10 Oct 2003 00:07:09 -0000 1.573
+++ erc.el 14 Oct 2003 16:07:36 -0000
@@ -962,12 +962,14 @@
name)
(interactive)
(add-to-list 'erc-modules (quote ,name))
+ (setq ,mode t)
,@enable-body)
(defun ,disable ()
,(format "Disable ERC %S mode."
name)
(interactive)
(setq erc-modules (delq (quote ,name) erc-modules))
+ (setq ,mode nil)
,@disable-body)
,(when (and alias (not (eq name alias)))
`(defalias
--
lawrence mitchell <we...@gm...>
|