[Erc-help] erc-bbdb fixes

[Andras B. <dr...@bi...>]

Hi,

I propose the following fixes to erc-bbdb.el 1.15:

--- erc-bbdb.el.old	Sun May 12 18:17:59 2002
+++ erc-bbdb.el	Sun May 12 23:58:46 2002
@@ -127,6 +127,7 @@
       (bbdb-annotate-notes record (or new-nick nick) erc-bbdb-irc-nick-field)
       (bbdb-annotate-notes record finger-host bbdb-finger-host-field)
       (and chan
+           (not (eq chan t))
 	   (bbdb-annotate-notes record chan erc-bbdb-irc-channel-field))
       (erc-bbdb-highlight-record record)
       (erc-bbdb-show-entry record chan proc))))
@@ -155,7 +156,7 @@
     (unless (string= nick (erc-current-nick))
       (let* ((finger-host (concat (nth 1 sender) "@" (nth 2 sender))))
 	(erc-bbdb-insinuate-and-show-entry erc-bbdb-auto-create-on-nick-p proc
-					   nick nil finger-host t (aref parsed 2))))))
+					   nick nil finger-host nil (aref parsed 2))))))
 
 (defun erc-bbdb-init-highlighting-hook-fun (proc parsed)
   (erc-bbdb-init-highlighting))
 
The first chunk is required because erc-bbdb-whois passes 't' as the
channel name in order to pop up the bbdb record, but this causes
(bbdb-annotate-notes record t erc-bbdb-irc-channel-field) to be
invoked in erc-bbdb-insinuate-and-show-entry, which is just wrong and
produces an error message.

The second chunk changes erc-bbdb-NICK to pass 'nil' instead of 't' to
erc-bbdb-insinuate-and-show-entry, which causes no popups to be
displayed. IMHO it's better than having popups about people who're on
hidden channels, but still not perfect. It should check if the person
who had changed his/her nick is on the channel that is being displayed
right now...

Regards,

-- 
BALI, Andra's                                      GPG KeyID: 78560E1C
dr...@bi..., ba...@de...                http://drewie.hup.hu
Debian GNU/Linux. The Universal Operating System.  http://www.debian.org