Re: [Erc-help] patch for some improvements

[<sm...@wa...>]

Mario Lang <ml...@ho...> writes:

> 1. Making erc-buffer-list global breaks multiple servers. I'd
> suggest introducing a variable named like erc-buffers, and write
> code for this in paralell. When this works, we can remove
> erc-buffer-list altogether.

Could you elaborate a bit on what needs to be implemented for this?

> 2. erc-insert-hook in line 150 of your patch is not quite right.
> erc-insert-hook takes two parameters since 1.73. start and end of
> inserted area. IMHO it should get called with the same values than
> erc-fill-region in that function. Perhaps (let it somewhere...

Ah, I thought that the optional arguments didn't matter.  I'll fix
this tonight.

> 3. I didnt like the name erc-message-notices, but perhaps that's
> just me. We already have erc-minibuffer-privmsgs, so perhaps name
> this erc-minibuffer-notices?

Good suggestion, I'll change it to that.  I love to hear more about
naming issues, even if you think you have a minor improvement for
anything, I think it's worth considering.  erc.el is already horribly
long, and adding more and more features will make the code harder to
read for humans.

-- 
Tijs van Bakel, <sm...@wa...>