Re: [Erc-help] patch for some improvements

[Mario L. <ml...@ho...>]

Hi smoke.

Cool patch, I only have three point of discussion:

1. Making erc-buffer-list global breaks multiple servers. I'd suggest
introducing a variable named like erc-buffers, and write
code for this in paralell. When this works, we can remove erc-buffer-list
altogether.

2. erc-insert-hook in line 150 of your patch is not quite right.
erc-insert-hook takes two parameters since 1.73. start and end of inserted
area. IMHO it should get called with the same values than erc-fill-region
in that function. Perhaps (let it somewhere...

I can fix this later...

3. I didnt like the name erc-message-notices, but perhaps
that's just me. We already have erc-minibuffer-privmsgs, so
perhaps name this erc-minibuffer-notices?

Otherwise, the patch is really cool and useful. Please check it in!

-- 
CYa,
   Mario <ml...@de...>
Homepage(s): http://delysid.org | http://piss.at/

LILO, you've got me on my knees!
	-- David Black, db...@pi..., with apologies to Derek and the
Dominos, and Werner Almsberger

CYa,
   Mario <ml...@de...>
Homepage(s): http://delysid.org | http://piss.at/

..you could spend *all day* customizing the title bar.  Believe me.  I
speak from experience."
(By Matt Welsh)