#20 hardcoding CMAKE_INSTALL_PREFIX is bad

[David Runge]

Due to the hardcoding of CMAKE_INSTALL_PREFIX and incomplete definition of LV2_BUNDLE in CMakeLists.txt users who want to build eq10q as a package or install it into their system have to use quite an uncommon approach in setting the installation path.

The prefix is usually used to distinguish between different system locations and never hardcoded, so users can override it (e.g. to install to /usr/lib instead of /usr/local/lib). It is not meant to set the complete path to where things are to be installed and on Unix-y systems defaults to /usr/local!

To actually set the path as a flag to cmake (usually something like: -DCMAKE_INSTALL_PREFIX=/usr) as it is supposed to work, users now have to first delete the declaration(s) of CMAKE_INSTALL_PREFIX in CMakeLists.txt and then give the whole path to the lv2 directory (e.g. -DCMAKE_INSTALL_PREFIX=/usr/lib/lv2).
However, modifying the LV2_BUNDLE declaration (i.e. set (LV2_BUNDLE "lib/lv2/sapistaEQv2.lv2")) in combination with the removal of the CMAKE_INSTALL_PREFIX declaration also works (for the standard system locations /usr/local/lib/lv2 and /usr/lib/lv2) and this should really be the preferred way of doing this, when looking at cmake's install documentation.

Please change these non-standard overrides, as they lead to lots of unnecessary hackery on the CMakeLists.txt before build. I do understand, that for some end users installing to ~/.lv2 might be desirable, but this can and should be achieved in other ways.