Menu

#64 HTML output contains style information

open
nobody
None
5
2007-07-31
2007-07-31
No

Hi,

I noted the HTML output contains style information in several places (Epydoc 3.0beta1). E.g. bgcolor, vlink, alink and width tags.

IMHO this information should be placed in the CSS file, which is easy, as each element also has an associated class.

Discussion

  • Edward Loper

    Edward Loper - 2007-08-01

    Logged In: YES
    user_id=195958
    Originator: NO

    This probably reflects the history of the code more than anything else -- when epydoc was written, css wasn't widely supported, so we had to make sure things would look good even if css was turned off. That's not so much of a problem now.

    Patches for this are welcome (preferably patched against svn).

     
  • Arjan Molenaar

    Arjan Molenaar - 2007-08-06

    remove style info from html template and put everything in css

     
  • Arjan Molenaar

    Arjan Molenaar - 2007-08-06

    Logged In: YES
    user_id=144333
    Originator: YES

    Hi,

    As you wished: here's a patch that removes the style information out of the html file. I checked to see if everything is placed in the css correctly (so it seems).

    I had to add a hack to the _COLOR_RE expression, since it handles id's as colors :(.

    While on the subject: I see a lot of tables being used. I already removed one (breadcrumbs), but most tabular data could be replaced by divs and some proper css. Are there any thoughts on this subject?

    File Added: epydoc-no-embedded-styles.patch

     
  • Björn Lindqvist

    Logged In: YES
    user_id=51702
    Originator: NO

    I like your patch alot. I also would really love to see more divs and less tables in epydoc to make it easier to customize the layout.

     
  • Arjan Molenaar

    Arjan Molenaar - 2007-09-06

    Logged In: YES
    user_id=144333
    Originator: YES

    More divs and less tables would be the next step indeed.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.