Re: Re[2]: Rif: Re: [Envolution-devel] GPL respect

[<s.k...@pr...>]

 ----- Original Message -----
From: "Furbo" <fu...@si...>
To: <env...@li...>
Sent: Wednesday, July 30, 2003 7:20 PM
Subject: Re[2]: Rif: Re: [Envolution-devel] GPL respect


> YES!   how is someone supposed to be able to (or required to) add
> proper comments if the comments are not there?  For me, I look at a
> file alone.  If the names are not there then its kind of hard for someone
to
> complain about it.. Yes, having names in a central file is nice and
> all but it can not be expected for someone to filter through a list of
> hundreds of names for all the developers of Envo to find the few that
> worked on a module or edited it..   Those who work on code should put
their names
> IN the code they change or at least in the module/file being changed.
>
> Now an issue could be argued that after the fact IF names were not in
> original file 'taken' from envo.. how is anyone to know who really did
> what work.. I know Brook and Larry will do their best to accommodate the
> original coders but look at it from a fraud point of view.. ANYONE
> could show up one day and say 'Oh, i worked on that' bc their name is
> in the Evno credits file but not in the modules comments.. a lot of
> people are in that central credits file but they dont deserve credit
> for all the code..  i would hate for a 'i did that too' war to break
> out over GPL code.

I agreed with all you say. But primarily all modifications were done for
eNvolution and not for public use in other projects like PN.
We from eNvo-DevTeam knows all what Luca has done in the codes. And this was
and is defintly a great job. Otherwise you from PN knows everything what
Brook, Larry and others done without including credits into the files.
So accept, that we have forgotten to pay attention to include names, credits
or something like this into the code. One reason for this I try to explain
it at the beginning in one sentence.

I'm not sure if someone from PN-DevTeam ask Luca to copy code (with his
modifications) from eNvo-CVS. So we have had the possibility to include
credits. Now everything is done and you have to put the credits into the
files. I'm sure you have copy&paste parts of our code into yours. I mean you
don't use our code 1:1 as it is.
The same applies to parts of our extended Encompass.
If I'm wrong correct me. I can't know everything....

To find out where are the modifications of Luca can be found, he has explain
it in one of his mails on this list.
You can grep the files for 'modified for oracle compatibility'. Then you
know where Oracle parts are inserted.

And again: This is a wish of Luca. He ask for it.
And we all have to respect credits that where putting into code all the same
of whom, where or what.
Ok you do so after best knowledge and certain. And we do so too.

And if someone don't want to insert his name as credits into the code, this
is also ok. Then it in addition, no requirements may place later.

For me, I insert my name into the code where ever I think it would be useful
(for comments, questions, etc.) not with priority of credits. And I ask the
author of the files if it is allowed to use it before modify it for my
needs.

For modules all forms of credits are possible, directly in the code, as
credits-file or as i.e. "powered by...." in the output form.
But what Luca has done were changes in the hiding. Without output. So there
is only one possibility remaining: To include credits into the code.

I don't see any problems with that. It is only a situation which is
solvable.

Stefan


 > YES!   how is someone supposed to be able to (or required to) add
> proper comments if the comments are not there?  For me, I look at a
> file alone.  If the names are not there then its kind of hard for someone
to
> complain about it.. Yes, having names in a central file is nice and
> all but it can not be expected for someone to filter through a list of
> hundreds of names for all the developers of Envo to find the few that
> worked on a module or edited it..   Those who work on code should put
their names
> IN the code they change or at least in the module/file being changed.
>
> Now an issue could be argued that after the fact IF names were not in
> original file 'taken' from envo.. how is anyone to know who really did
> what work.. I know Brook and Larry will do their best to accommodate the
> original coders but look at it from a fraud point of view.. ANYONE
> could show up one day and say 'Oh, i worked on that' bc their name is
> in the Evno credits file but not in the modules comments.. a lot of
> people are in that central credits file but they dont deserve credit
> for all the code..  i would hate for a 'i did that too' war to break
> out over GPL code.
>
> > For future modifications the best way to ensure proper credit is to
> > comment your changes directly in the file you are modifying. A simple:
> > /* modified by 'your name here' */ usually works well.
>
> Agreed  put the credits with the code if people want proper credit for
> changing things..  i know it can be a pain, but thats life.  If you
> want credit for something make sure ANYONE who looks at the code (just
> that 1 file) can tell.  You can not expect (and i dont think the GPL
> requires) that people hunt for the credits..
>
> > Zoom
>
>
> --
> Furbo
>